Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note about environment variable DOTNET_EnableDiagnostics #3291

Merged
merged 1 commit into from May 13, 2024

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented May 10, 2024

This adds some instructions how to make sure profiling is working in dotnet 8.

image

See dotnet/runtime#96227

@simonswine simonswine changed the title Add warning about environment variables Docs: Add note about environment variable DOTNET_EnableDiagnostics May 10, 2024
@simonswine simonswine added type/docs Improvements for doc docs. Used by Docs team for project management backport release/v1.5 This label will backport a merged PR to the release/v1.5 branch labels May 10, 2024
@simonswine simonswine marked this pull request as ready for review May 10, 2024 12:23
@simonswine simonswine requested review from a team as code owners May 10, 2024 12:23
@simonswine simonswine changed the title Docs: Add note about environment variable DOTNET_EnableDiagnostics docs: Add note about environment variable DOTNET_EnableDiagnostics May 10, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@simonswine simonswine merged commit 7aaf8e1 into grafana:main May 13, 2024
18 checks passed
github-actions bot pushed a commit that referenced this pull request May 13, 2024
Copy link
Contributor

The backport to release/v1.5 failed:

Validation Failed: "Could not resolve to a node with the global id of 'T_kwDOAG3Mbc4AczmP'."

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3291-to-release/v1.5 origin/release/v1.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 7aaf8e1e172982143f1913de0ff9fcc6689b60c8

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3291-to-release/v1.5
# Create the PR body template
PR_BODY=$(gh pr view 3291 --json body --template 'Backport 7aaf8e1e172982143f1913de0ff9fcc6689b60c8 from #3291{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release/v1.5] docs: Add note about environment variable `DOTNET_EnableDiagnostics`" --body-file - --label "type/docs" --label "backport" --base release/v1.5 --milestone release/v1.5 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3291-to-release/v1.5

# Create a pull request where the `base` branch is `release/v1.5` and the `compare`/`head` branch is `backport-3291-to-release/v1.5`.

# Remove the local backport branch
git switch main
git branch -D backport-3291-to-release/v1.5

simonswine added a commit that referenced this pull request May 13, 2024
(cherry picked from commit 7aaf8e1)

Co-authored-by: Christian Simon <simon@swine.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.5 This label will backport a merged PR to the release/v1.5 branch backport-failed type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants