Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet examples to SDK version 8 #3288

Closed
wants to merge 1 commit into from

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented May 9, 2024

Unfortunately, this doesn't work for me on Apple M2, with rosetta I get build errors, works on my linux/amd64 machine though:

# For musl
$ docker buildx build --load --platform linux/amd64 examples/language-sdk-instrumentation/dotnet/rideshare/  -f examples/language-sdk-instrumentation/dotnet/rideshare/musl.Dockerfile
[...]
 => ERROR [stage-0 6/6] RUN dotnet publish -o . -r $(dotnet --info | grep RID | cut -b 6- | tr -d ' ')                                                                                                                                          1.7s
------
 > [stage-0 6/6] RUN dotnet publish -o . -r $(dotnet --info | grep RID | cut -b 6- | tr -d ' '):
1.564 The expression "[MSBuild]::GetTargetPlatformIdentifier('')" cannot be evaluated. Exception has been thrown by the target of an invocation.  /usr/share/dotnet/sdk/8.0.204/Sdks/Microsoft.NET.Sdk.Web/Sdk/Sdk.props
1.581 MSBuild version 17.9.8+b34f75857 for .NET
------

# For glibc
$ docker buildx build --load --platform linux/amd64 examples/language-sdk-instrumentation/dotnet/rideshare/
  => ERROR [stage-0 6/6] RUN dotnet publish -o . -r $(dotnet --info | grep RID | cut -b 6- | tr -d ' ')                                                                                                                                          1.7s
------
 > [stage-0 6/6] RUN dotnet publish -o . -r $(dotnet --info | grep RID | cut -b 6- | tr -d ' '):
1.634 terminate called after throwing an instance of 'PAL_SEHException'
1.639 Aborted

Not really too sure if that is something broken locally, wonder if some of you could give it a try before merging. @grafana/pyroscope-dotnet

@simonswine simonswine marked this pull request as ready for review May 13, 2024 13:21
@simonswine simonswine requested a review from a team as a code owner May 13, 2024 13:21
@bryanhuhta
Copy link
Contributor

Unfortunately, this doesn't work for me on Apple M2, with rosetta I get build errors

I recall @aleks-p had to use his personal Windows machine to develop the .NET span profiles feature for this exact reason.

Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have access to Apple M2 devices, so I can't verify this works. Approving so you can merge since you already were able to check on a non-M2 device.

@simonswine
Copy link
Contributor Author

@korniltsev also reported this stops working with his orb/docker on linux/amd64 setup. Let's keep the sdk6 then

@simonswine simonswine closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants