Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds README for node #3212

Merged
merged 5 commits into from May 24, 2024
Merged

docs: adds README for node #3212

merged 5 commits into from May 24, 2024

Conversation

petethepig
Copy link
Member

No description provided.

@petethepig petethepig requested a review from a team as a code owner April 12, 2024 18:11
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the REAME. I've added two minor suggestions.

@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Apr 12, 2024
@simonswine simonswine added the backport release/v1.5 This label will backport a merged PR to the release/v1.5 branch label Apr 24, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@knylander-grafana
Copy link
Contributor

@petethepig I did another quick review and found a missing comma. Everything looks good. Okay to merge?

@knylander-grafana knylander-grafana removed the backport release/v1.5 This label will backport a merged PR to the release/v1.5 branch label May 16, 2024
@simonswine simonswine merged commit f6de564 into main May 24, 2024
16 checks passed
@simonswine simonswine deleted the nodejs branch May 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants