New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: symdb custom binary format #3138
Open
kolesnikovae
wants to merge
40
commits into
main
Choose a base branch
from
feat/symdb-strings-encoding
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,307
−871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
changed the title
feat: symdb strings encoding
feat: symdb custom binary format
Mar 27, 2024
Do we need to update the docs for this feature? |
@knylander-grafana, I'll update the https://grafana.com/docs/pyroscope/latest/reference-pyroscope-architecture/block-format page – just a couple of lines, nothing very important |
knylander-grafana
added
the
type/docs
Improvements for doc docs. Used by Docs team for project management
label
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the reference architecture.
kolesnikovae
added
storage
Low level storage matters
performance
If there's anything we have to be really good at it's this
labels
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
performance
If there's anything we have to be really good at it's this
storage
Low level storage matters
type/docs
Improvements for doc docs. Used by Docs team for project management
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2926
The change eliminates the use of parquet tables from symdb. This significantly improves read selectivity for symbolic information and, more importantly, enables fetching symbolic information directly from blocks in the object storage without the need to keep parquet files open in memory (in ingesters and store-gateways).
Note that the new format is not enabled by default. This is done for backward compatibility purposes (a feature flag, of sorts). Later, after more intensive internal testing, the format will be enabled by default.
Compression
The new encoding allows to achieve up to 30% reduction in size on disk.
Using the current encoding and block layout:
Encoded in the new format:
Performance
Even though the change was not aimed at directly optimizing performance in terms of query latencies, benchmarks show a ~10-20% reduction in the overall query duration for
SelectMergeByStacktraces
:Single service:
The whole block (
{}
):The test dataset comprises real-life data from one of the internal deployments – 1GB collected over one hour.