feat(otlp): experimental otlp support #2177
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petethepig
commented
Jul 27, 2023
•
petethepig
commented
- very much a draft at this point.
- requires a copy of https://github.com/open-telemetry/opentelemetry-proto-profile to be adjacent to the directory
- works with feat(otlp): experimental otlp support pyroscope-go#36 and Adds profiles as another signal petethepig/opentelemetry-collector#1
cyriltovena
reviewed
Jul 27, 2023
pkg/api/api.go
Outdated
| a.RegisterRoute("/ingest", pyroscopeHandler, true, true, "POST") | ||
| a.RegisterRoute("/pyroscope/ingest", pyroscopeHandler, true, true, "POST") | ||
| pushv1connect.RegisterPusherServiceHandler(a.server.HTTP, d, a.grpcAuthMiddleware) | ||
| a.RegisterRoute("/distributor/ring", d, false, true, "GET", "POST") | ||
| a.indexPage.AddLinks(defaultWeight, "Distributor", []IndexPageLink{ | ||
| {Desc: "Ring status", Path: "/distributor/ring"}, | ||
| }) | ||
|
|
||
| pprofileotlp.RegisterGRPCServer(a.server.GRPC, otlpHandler) |
There was a problem hiding this comment.
Just so you know I don't think we expose GRPC endpoint anywhere in our infra nor in helm.
There was a problem hiding this comment.
@cyriltovena yeah we might need a separate grpc server
petethepig
commented
Jul 28, 2023
go.mod
Outdated
| go.opentelemetry.io/collector/pdata v1.0.0-rcv0012 | ||
| ) | ||
|
|
||
| replace go.opentelemetry.io/collector/pdata => ../opentelemetry-collector/pdata |
There was a problem hiding this comment.
to be clear, we won't have this dependency once this is ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.