ingester: ActiveSeriesRequest can return native histograms information #7986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
force-pushed
the
krajo/native-histograms-cardinality-api
branch
2 times, most recently
from
b8fdaa7
to
1b4938c
Compare
krajorama
force-pushed
the
krajo/native-histograms-cardinality-api
branch
from
1b4938c
to
7660981
Compare
krajorama
changed the title
krajorama
force-pushed
the
krajo/native-histograms-cardinality-api
branch
from
7660981
to
8539e11
Compare
Allow ActiveSeriesRequest to return only native histograms and include active bucket count in the label __nh_bucket_count__ Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
flxbk
previously approved these changes
Apr 29, 2024
This comment was marked as outdated.
This comment was marked as outdated.
krajorama
force-pushed
the
krajo/native-histograms-cardinality-api
branch
from
8539e11
to
e19a6b2
Compare
Labels are already packed due to tag==stringlabels in TSDB so Add() doesn't work on them. And after they are decoded for the response we'd have to insert the bucket count label into the correctly sorted position which would mean never being able to just send the encoded labels. Instead of adding a new interface I'll add a backwards compatible array of integers as a compromise. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
dismissed
flxbk’s stale review
I had to change the implementation to account for tag=stringlabels
|
flxbk
reviewed
May 2, 2024
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
ingester: ActiveSeriesRequest can return native histograms information
The interface
ActiveSeries(ActiveSeriesRequest), gets a newTypefield that requests active series by default (0) but can request native histograms (1). In case of histograms the new bucket_count array is filled with bucket counts in the response. Both these changes should be backwards compatible, enabling a smooth upgrade.Internally I flipped the order of postings iterators from sharding over active series to filtering active native histogram series over sharding to be able to get the bucket counts from the postings iterator directly. Also removes the use of the intermediate postings list to be able to directly stream the results.
Two alternative were considered:
Which issue(s) this PR fixes or relates to
Related to #7981
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.