Un-replace grpc dep and upgrade to v1.41.0 #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the replace directive for grpc package and upgraded to 1.41.0 which will be needed for the further Prometheus upgrade anyway. Checked all the concerned usages of `From.+Context()` and all of them use lowercase constants, so changes from grpc/grpc-go#4767 should not affect this code. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
pstibrany
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
LGTM, thank you!
I checked list of changes between release 1.38.0 and 1.41.0, and I don't see anything that would impact our usage.
I don't think grpc/grpc-go#4416 is a concern, because metadata is transported as http2 headers, which are always lowercase, and if we used upper-case anywhere, it would already be broken (converted to lowercase when transferred and then unavailable when accessing it via upper-case key). grpc/grpc-go#4416 fixes access to always use lower-case keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Removed the replace directive for grpc package and upgraded to 1.41.0
which will be needed for the further Prometheus upgrade anyway.
Checked all the concerned usages of
From.+Context()and all of themuse lowercase constants, so changes from
grpc/grpc-go#4767 should not affect this code.
gRPC library releases: https://github.com/grpc/grpc-go/releases
Which issue(s) this PR fixes:
None, just preparing for Prometheus upgrade in #683 without creating more Tech Debt.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]