New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: add NOTES.txt #2189
Merged
Merged
Helm: add NOTES.txt #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a NOTES.txt that prints the endpoints that will be usable by the user for interacting with mimir/gem. Currently helm does not support rendering the NOTES for testing. Rage/vote here: helm/helm#6901 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Actually /prometheus is configurable, use its template Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Rendered output for my gem install:
|
jdbaldry
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
From the CI test:
|
Small nit, add "the" in from of "values". |
1 task
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Jul 11, 2022
* Helm: add NOTES.txt Add a NOTES.txt that prints the endpoints that will be usable by the user for interacting with mimir/gem. Currently helm does not support rendering the NOTES for testing. Rage/vote here: helm/helm#6901 Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add a NOTES.txt that prints the endpoints that will be usable by the user
for interacting with mimir/gem.
Currently helm does not support rendering the NOTES for testing.
Rage/vote here: helm/helm#6901
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]