Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Thanos and its dependencies #1715

Merged
merged 3 commits into from Apr 20, 2022
Merged

Upgrade Thanos and its dependencies #1715

merged 3 commits into from Apr 20, 2022

Conversation

pracucci
Copy link
Collaborator

What this PR does

In this PR I'm upgrading Thanos and some dependencies coming with it. Thanos changes are minimal, but include a couple of fixes we want:

I checked the other upgraded dependencies, and LGTM:

  • github.com/prometheus/client_golang from v1.11.0 to v1.12.1: checked the release notes, added support for go 1.17 metrics collector and TSDB API, some enhancements
  • google.golang.org/grpc from v1.41.1 to v1.43.0: checked the release notes, API and behaviour changes shouldn't affect us
  • github.com/felixge/httpsnoop from v1.0.1 to v1.0.2: checked the diff and changes look safe to me. The removal of the mutex in this PR makes sense to me
  • github.com/aws/aws-sdk-go from v1.42.28 to v1.42.31: checked the diff, just added new endpoints

Which issue(s) this PR fixes or relates to

Fixes #1654

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@aknuds1
Copy link
Contributor

aknuds1 commented Apr 19, 2022

Linting fails, AFAICT due to gRPC upgrade.

…of the deprecated grpc.WithInsecure()

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci
Copy link
Collaborator Author

Linting fails, AFAICT due to gRPC upgrade.

Right. I've replaced grpc.WithInsecure() (now deprecated) with grpc.WithTransportCredentials(insecure.NewCredentials()). Under the hood they're the exact same.

Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memcached dns+ addresses resolve from CNAME
3 participants