Add query sharding support to ingesters #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
commented
Aug 16, 2021
| _, err = i.v2Push(ctx, req) | ||
| require.NoError(t, err) | ||
|
|
||
| // Push all series. We push half of the series, then we compact the TSDB head into a block (flush) |
There was a problem hiding this comment.
Instead of adding a new test, I've preferred extending TestIngester_v2QueryStream() so that we further improve it (eg. now it both queries compacted block and head, instead of just head). The diff is a bit difficult to read: I suggest to read the whole new implementation of this test.
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
add-sharding-support-to-ingesters
branch
from
1b60014
to
c3f4560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In grafana/mimir-prometheus#1 we've added sharding support to TSDB. In this PR I'm leveraging on that to add query sharding support to ingesters. The logic is pretty easy: when a query has the sharding label, than pass it along with
SelectHintsdown to TSDB.Draft because it builds on top of #139.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]