operator: Update golang to 1.20; Update dependencies to latest #8776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Red-GV
force-pushed
the
operator-update-dependencies
branch
from
9feaafb
to
1479585
Compare
periklis
requested changes
Mar 11, 2023
| @@ -5,5 +5,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
| images: | |||
| - name: controller | |||
| newName: quay.io/openshift-logging/loki-operator | |||
| newTag: v0.1.0 | |||
There was a problem hiding this comment.
Needs to be reverted back
|
@Red-GV I suggest to consider adding the following |
periklis
requested changes
Mar 13, 2023
periklis
requested changes
Mar 13, 2023
There was a problem hiding this comment.
Testing this on upcoming releases of OpenShift 4.13 requires the following patch:
@@ -259,7 +259,7 @@ olm-deploy: ## Deploy the operator bundle and the operator via OLM into an Kube
$(error Set variable REGISTRY_BASE to use a custom container registry org account for local development)
else
olm-deploy: olm-deploy-bundle olm-deploy-operator $(OPERATOR_SDK)
- $(OPERATOR_SDK) run bundle -n $(LOKI_OPERATOR_NS) --install-mode AllNamespaces $(BUNDLE_IMG)
+ $(OPERATOR_SDK) run bundle -n $(LOKI_OPERATOR_NS) --install-mode AllNamespaces $(BUNDLE_IMG) --security-context-config restricted
endif
Red-GV
force-pushed
the
operator-update-dependencies
branch
from
7c9692a
to
5049406
Compare
Red-GV
force-pushed
the
operator-update-dependencies
branch
from
5049406
to
d50426e
Compare
|
@periklis No major |
periklis
approved these changes
Mar 13, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates go to 1.20, Kubernetes dependencies to 1.26.2, OpenShift dependencies to release-4.13, and updates most of the bingo tools.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdateddocs/sources/upgrading/_index.md