logcli: add --proxy-url flag for http/https proxy support #6484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `--proxy-url` flag to `logcli` to support connecting to Loki instances running behind either HTTP or HTTPS CONNECT-style proxies. Examples: http proxy: ``` logcli \ --addr="http://loki-distributed-querier.loki.svc.cluster.local.:3100/" \ --proxy-url "http://envoy.dom.tld" \ query '{app"foo"}' ``` https proxy with mTLS auth: ``` logcli \ --addr="https://loki-distributed-querier.loki.svc.cluster.local.:3100/" \ --proxy-url "https://envoy.dom.tld" \ --cert tls.crt \ --key tls.key \ --ca-cert ca.crt \ query '{app"foo"}' ``` Note that tail (`-f`) support and https proxies only works with a fork of the `gorilla/websocket` lib. There are open PRs that promise to add support for https proxies such as: gorilla/websocket#740 Add the following to `go.mod` to use the fork with https support: ``` replace github.com/gorilla/websocket v1.4.2 => github.com/philipatl/websocket v1.4.3-0.20211206152948-d16969baa130 ```
|
|
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
dannykopping
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Thanks for the contribution @joemiller 🙌 this is great
Do you mind opening a separate issue for the tail functionality pls?
|
@dannykopping opened #6499 tnx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--proxy-urlflag tologclito support connecting to Loki instances running behind either HTTP or HTTPS CONNECT-style proxies.Examples:
http proxy:
https proxy with mTLS auth:
Note that tail (
-f) support and https proxies only work with a fork of thegorilla/websocketlib. There are open PRs that promise to add support for https proxies such as: gorilla/websocket#740Add the following to
go.modto use the fork with https support:I am maintaining a separate branch that includes the vendor'd fork here: https://github.com/planetscale/loki/tree/proxy-support
What this PR does / why we need it:
This PR makes it possible to connect
logclito Loki instances behind forward/CONNECT http and https proxies. This is already supported by other tools in this repo such aspromtailvia itsproxy_urlconfig flag.Special notes for your reviewer:
Checklist
CHANGELOG.md.docs/sources/upgrading/_index.md