Revert to working version of Azure client #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Revert SDK to working version - Introduce patches to prevent deadlocks
MasslessParticle
requested review from
KMiller-Grafana and
a team
as code owners
cyriltovena
reviewed
Feb 16, 2022
| type RoundTripperFunc func(*http.Request) (*http.Response, error) | ||
|
|
||
| func (fn RoundTripperFunc) RoundTrip(req *http.Request) (*http.Response, error) { | ||
| return fn(req) | ||
| } | ||
|
|
||
| func Test_Hedging(t *testing.T) { | ||
| metrics := NewBlobStorageMetrics() |
There was a problem hiding this comment.
Can you keep this global ? it will make count=10 test fails which helps figuring flaky tests.
cyriltovena
reviewed
Feb 16, 2022
owen-d
approved these changes
Feb 16, 2022
bboreham
reviewed
Mar 4, 2022
| @@ -288,7 +281,6 @@ require ( | |||
| github.com/cloudflare/cloudflare-go v0.27.0 | |||
| github.com/gofrs/flock v0.7.1 // indirect | |||
| github.com/gogo/status v1.1.0 | |||
| github.com/grafana/regexp v0.0.0-20220202152701-6a046c4caf32 | |||
There was a problem hiding this comment.
Was this an intentional change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
context cancelederrors originating in the new Azure SDK, we've decided to stabilize things by forking/patching the deprecated sdk client so we can have time to investigate the new client.This PR does two things:
SDK fork exists here: https://github.com/MasslessParticle/azure-storage-blob-go