Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic: exemplar labels have 85 runes, exceeding the limit of 64 #6667

Closed
liguozhong opened this issue Jul 12, 2022 · 7 comments
Closed

panic: exemplar labels have 85 runes, exceeding the limit of 64 #6667

liguozhong opened this issue Jul 12, 2022 · 7 comments

Comments

@liguozhong
Copy link
Contributor

liguozhong commented Jul 12, 2022

Describe the bug
A clear and concise description of what the bug is.

/Users/fuling/go/pkg/mod/github.com/liguozhong/loki@v1.6.2-0.20220712032519-992e483b6271/pkg/storage/chunk/cache/instrumented.go:95 +0x1af

here

image

image

https://github.com/prometheus/client_golang/blob/main/prometheus/value.go
image

To Reproduce
Steps to reproduce the behavior:

  1. Started Loki (SHA or version)
  2. Started Promtail (SHA or version) to tail '...'
  3. Query: {} term

Expected behavior
A clear and concise description of what you expected to happen.

Environment:

  • Infrastructure: [e.g., Kubernetes, bare-metal, laptop]
  • Deployment tool: [e.g., helm, jsonnet]

Screenshots, Promtail config, or terminal output
If applicable, add any output to help explain your problem.

@bboreham
Copy link
Contributor

Should be addressed by weaveworks/common#247.
Also note prometheus/client_golang#1091

@John-Lin
Copy link

Same issue here when we upgrade to distributed Loki v2.6.1. distributors have same error message.
We disable the tracing feature for workaround.

@liguozhong
Copy link
Contributor Author

liguozhong commented Aug 31, 2022

this pr has fix this issue.
#6859

update dependency weaveworks/common#249
and weaveworks/common#247 has fix

@periklis
Copy link
Collaborator

Isn't this address by #6957 already?

@liguozhong
Copy link
Contributor Author

6859>6957 , so I don't think 6957 has fixed this yet

@periklis
Copy link
Collaborator

periklis commented Sep 2, 2022

The issue is imho fixed by bumping the prometheus/client_golang to 1.13 with #6957. The changelog of client_golang (https://github.com/prometheus/client_golang/releases/tag/v1.13.0) mentions:

[BUGFIX] Raise exemplar labels limit from 64 to 128 bytes as specified in OpenMetrics spec. https://github.com/prometheus/client_golang/pull/1091

@bboreham
Copy link
Contributor

bboreham commented Sep 2, 2022

One change removes the thing that made exemplar labels longer, the other raises the exemplar length limit.

Either way I agree it can be closed.

@bboreham bboreham closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants