Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving logic with conditions and persistent test run ID #213

Merged
merged 2 commits into from Apr 24, 2023

Conversation

yorugac
Copy link
Collaborator

@yorugac yorugac commented Apr 12, 2023

This PR is meant as the next step to improve the idempotence problem described in #138. Specifically, it introduces simultaneous test runs with cloud output, increases robustness of the operator and introduces some API additions.

The key changes here are:

  1. test run ID became part of the K6 status: this unlocks simultaneous test runs with cloud output since each K6 CR is unique now.
  2. using conditions to track some key characteristics of the test run: this allows a far more fine-grained logic in the controller than before.
  3. the long overdue refactoring of the logic has been hinted at but should be addressed further in the next PR(s).

Both test run ID and conditions can also be referenced as part of API.

✔️ This must be merged after PR #212 since it's built on top of that one.

@yorugac yorugac merged commit 3b623e2 into main Apr 24, 2023
9 checks passed
@yorugac yorugac deleted the status-conditions branch April 24, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant