Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for k6 v0.29.0 #144

Merged
merged 28 commits into from Nov 11, 2020
Merged

Changes for k6 v0.29.0 #144

merged 28 commits into from Nov 11, 2020

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Nov 2, 2020 •
edited

This is a WIP branch PR for all v0.29.0 documentation

@mstoykov mstoykov requested review from na-- and imiric November 2, 2020 11:02
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

There's a version of the docs published here:

https://mdr-ci.staging.k6.io/docs/refs/pull/144/merge

It will be deleted automatically in 30 days.

@ppcano
Copy link
Collaborator

ppcano commented Nov 3, 2020 •
edited by mstoykov

@mstoykov
Copy link
Contributor Author

mstoykov commented Nov 4, 2020

I propose we merge the gRPC one here as well and merge this in master when we make the release?

@na-- na-- changed the title Changes for0.29.0 Changes for k6 v0.29.0 Nov 10, 2020
na--
na-- reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also rebase this on master and cherry-pick the commits from #110 on top of the ones here. They'd also need some minor edits and it'd be easier and quicker to do it in our branch.

src/data/markdown/docs/01 guides/02 Using k6/05 Options.md Outdated Show resolved Hide resolved
src/data/markdown/docs/02 javascript api/06 k6-http/61 Response.md Outdated Show resolved Hide resolved
src/data/markdown/docs/01 guides/02 Using k6/05 Options.md Show resolved Hide resolved
src/data/markdown/docs/01 guides/02 Using k6/05 Options.md Show resolved Hide resolved
src/data/markdown/docs/01 guides/02 Using k6/05 Options.md Outdated Show resolved Hide resolved
src/data/markdown/docs/01 guides/02 Using k6/05 Options.md Outdated Show resolved Hide resolved
src/data/markdown/docs/01 guides/02 Using k6/05 Options.md Show resolved Hide resolved
@na--
More fixes
74f9516
@na--
Try to fix the left menu
2d82567
@na--
Add a protocols blurb for gRPC
8c624b2 
Introductory sentences were copied from @simskij's upcoming blog post
@na-- na-- requested a review from simskij November 11, 2020 12:02
mstoykov
mstoykov commented Nov 11, 2020
View reviewed changes
Copy link
Contributor Author

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

imiric
imiric reviewed Nov 11, 2020
View reviewed changes
src/data/markdown/docs/01 guides/02 Using k6/05 Options.md Outdated Show resolved Hide resolved
src/data/markdown/docs/01 guides/02 Using k6/05 Options.md Outdated Show resolved Hide resolved
src/data/markdown/docs/01 guides/02 Using k6/05 Options.md Outdated Show resolved Hide resolved
src/data/markdown/docs/02 javascript api/06 k6-http/61 Response.md Outdated Show resolved Hide resolved
src/data/markdown/docs/02 javascript api/09 k6-net-grpc.md Outdated Show resolved Hide resolved
src/data/markdown/docs/02 javascript api/09 k6-net-grpc.md Outdated Show resolved Hide resolved
...own/docs/02 javascript api/09 k6-net-grpc/20 Client/10-Client-load-importpaths-protoFiles.md

| Parameter | Type | Description |
|-----------|------|-------------|
| importPaths | Array<string> \| `null` | The paths used to search for dependencies that are referenced in import statements in proto source files. If no import paths are provided then "." (current directory) is assumed to be the only import path. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention if absolute paths are supported, any compatibility issues on Windows, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are technically supported - you can use absolute paths on windows and on linux. The problems occur when you use absolute paths on Windows with k6 cloud, since we then execute the archives on linux machines. It's technically a k6 bug, so we are going to eventually fix it, it's just tricky to do so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am more for ... not allowing absolute paths ... but regardless I think the wording here is fine

...wn/docs/02 javascript api/09 k6-net-grpc/20 Client/30-Client-invokerpc-url-request-params.md Show resolved Hide resolved
src/data/markdown/docs/02 javascript api/09 k6-net-grpc/20-Params.md Outdated Show resolved Hide resolved
src/data/markdown/docs/02 javascript api/09 k6-net-grpc/20-Params.md Show resolved Hide resolved
na-- and others added 2 commits November 11, 2020 14:31
@na--
Apply suggestions from code review
5aff52b 
Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
@na--
Fix typos and timeout values
090f7c3
@na-- na-- merged commit bb7b1fc into master Nov 11, 2020
@na-- na-- deleted the changesFor0.29.0 branch November 11, 2020 12:37
@na-- na-- mentioned this pull request Nov 11, 2020
Closed
simskij pushed a commit that referenced this pull request Nov 16, 2020
@mstoykov @na--
@rogchap @simskij
Changes for k6 v0.29.0 (#144)
dc99d0d 
Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
Co-authored-by: na-- <n@andreev.sh>
Co-authored-by: Roger Chapman <rogchap@gmail.com>
simskij pushed a commit that referenced this pull request Nov 16, 2020
@mstoykov @na--
@rogchap @simskij
Changes for k6 v0.29.0 (#144)
af4bf3c 
Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
Co-authored-by: na-- <n@andreev.sh>
Co-authored-by: Roger Chapman <rogchap@gmail.com>
@simskij simskij mentioned this pull request Nov 16, 2020
Closed
@na-- na-- mentioned this pull request Nov 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiric imiric imiric left review comments

@na-- na-- na-- approved these changes

@simskij simskij Awaiting requested review from simskij

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mstoykov @ppcano @imiric @na-- @rogchap