Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grafana agent down alert #1225

Closed
wants to merge 1 commit into from

Conversation

mshahzeb
Copy link
Contributor

@mshahzeb mshahzeb commented May 8, 2024

Fixes: https://github.com/grafana/support-escalations/issues/10404

The alert does not fire if the up metric is not scraped which can happen if the agent goes down.

@mshahzeb mshahzeb requested a review from a team as a code owner May 8, 2024 00:35
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this!

@v-zhuravlev
Copy link
Contributor

think it will fire only there is NO SINGLE metric up with label integrations/agent. Is this what expected?

@mshahzeb
Copy link
Contributor Author

@v-zhuravlev

This is supposted to fire if there is an up metric and it is showing 0 or if the up metric is missing (If the agent service is killed)

expr: |||
              up{
                job="integrations/agent",
              } == 0
              or absent(
                up{
                  job="integrations/agent",
                }
              )
            |||,
            'for': '5m',

Related issue: grafana/support-escalations#10404

@mshahzeb
Copy link
Contributor Author

After internal discussion, we have discussed not to change this behavior because:

  • The service can be down for any number of reasons (e.g maintenance, planned shutdown) or issues with metric ingestion (There might be an issue on Grafana side due to which the metric is not being ingested)
  • Therefore it is safe to trigger this only if the up metric is being reported and it is reporting 0

This alert is very prone to false positives and we are not comfortable in making this change globally for all everyone.

@mshahzeb mshahzeb closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants