[grafana] Improve dashboard variable substitution #3120
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toanju
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
|
The Grafana dashboard variable syntax allows varnames without curly
braces ($datasource and ${datasource}). A substitution can only be
applied for the latter. This enables extended regular expressions for
sed to allow both substitutions to take place to include dashboards that
are written in either form.
Signed-off-by: Tobias Jungel <tobias.jungel@gmail.com>
toanju
changed the title
Signed-off-by: Tobias Jungel <tobias.jungel@gmail.com>
Signed-off-by: Tobias Jungel <tobias.jungel@gmail.com>
zanhsieh
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Grafana dashboard variable syntax allows varnames without curly braces (
$datasource and ${datasource}). A substitution can only be applied for the latter. This enables extended regular expressions for sed to allow both substitutions to take place to include dashboards that are written in either form.