[grafana] Adding configmap annotation #3064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiszczak83
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
|
… with ArgoCD in case configmap is too big. Signed-off-by: jmiszczak <jaroslaw.miszczak83@gmail.com> Signed-off-by: Jaroslaw Miszczak <jaroslaw.miszczak83@gmail.com>
|
Hi @maorfr @torstenwalter @Xtigyro @zanhsieh can maybe any of you review the PR. It would be nice to have this fix merged. |
zanhsieh
changed the title
zanhsieh
approved these changes
May 16, 2024
|
@zanhsieh thank you for the approval. now we just need another one. |
|
Hi, guys, there is a +1 for this merge. @torstenwalter , @Xtigyro , @maorfr , could someone make a PR, please? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1811
Adding configmap annotation with example in values file how to use it with ArgoCD in case configmap is too big.