Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltip to instances of IconButton #68880

Merged
merged 24 commits into from
Jun 8, 2023
Merged

Add tooltip to instances of IconButton #68880

merged 24 commits into from
Jun 8, 2023

Conversation

L-M-K-B
Copy link
Contributor

@L-M-K-B L-M-K-B commented May 23, 2023 •
edited

Relates to issue #66346

This PR contains changes to local use cases of IconButton to make sure a11y gets improved.

@L-M-K-B L-M-K-B added area/frontend add to changelog type/accessibility Accessibility problem / enhancement no-backport Skip backport of PR labels May 23, 2023
@L-M-K-B L-M-K-B added this to the 10.0.x milestone May 23, 2023
@L-M-K-B L-M-K-B requested review from a team and ryantxu as code owners May 23, 2023 10:49
@L-M-K-B L-M-K-B requested review from Jguer, danielkenlee, aangelisc, alyssabull, dprokop, evictorero, joshhunt and tskarhed and removed request for a team May 23, 2023 10:49
ashharrison90
ashharrison90 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this looks fantastic 👏

edit: the milestone for this is set to 10.0.x, but since we're not backporting (which i don't think we should) this will go into 10.1.x

@L-M-K-B L-M-K-B added the breaking change Relevant for changelog generation label Jun 5, 2023
@L-M-K-B L-M-K-B modified the milestones: 10.0.x, 10.1.x Jun 5, 2023
@ckbedwell ckbedwell added the wcag/3.3.2 Labels or instructions are provided when content requires user input. label Jun 5, 2023
@L-M-K-B
Copy link
Contributor Author

L-M-K-B commented Jun 7, 2023

In order to separate immediate changes in IconButton use cases and the required breaking change in the IconButton component I will remove changes in packages/grafana-ui/src/components/IconButton/IconButton.tsx from this PR and handle them in another one (see #69699). So we can get local a11y improvements in without having to wait for the breaking change to be published.

@L-M-K-B L-M-K-B added no-changelog Skip including change in changelog/release notes and removed add to changelog breaking change Relevant for changelog generation labels Jun 7, 2023
@L-M-K-B L-M-K-B changed the title GrafanaUI: Define tooltip as required Add tooltip to instances of IconButton Jun 7, 2023
@L-M-K-B L-M-K-B merged commit 24502c4 into main Jun 8, 2023
16 of 17 checks passed
@L-M-K-B L-M-K-B deleted the laura/refactor/iconbutton-define-tooltip-as-required branch June 8, 2023 08:23
@kaydelaney kaydelaney mentioned this pull request Jun 13, 2023
Closed
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhunt joshhunt joshhunt left review comments

@academo academo academo left review comments

@tolzhabayev tolzhabayev tolzhabayev left review comments

@tskarhed tskarhed tskarhed left review comments

@JoaoSilvaGrafana JoaoSilvaGrafana JoaoSilvaGrafana left review comments

@aangelisc aangelisc aangelisc approved these changes

@nmarrs nmarrs nmarrs approved these changes

@ivanahuckova ivanahuckova ivanahuckova approved these changes

@alyssabull alyssabull alyssabull approved these changes

@ryantxu ryantxu Awaiting requested review from ryantxu ryantxu is a code owner

@Jguer Jguer Awaiting requested review from Jguer Jguer was automatically assigned from grafana/grafana-authnz-team

@danielkenlee danielkenlee Awaiting requested review from danielkenlee danielkenlee was automatically assigned from grafana/grafana-authnz-team

@dprokop dprokop Awaiting requested review from dprokop dprokop is a code owner automatically assigned from grafana/dashboards-squad

@evictorero evictorero Awaiting requested review from evictorero evictorero is a code owner automatically assigned from grafana/dashboards-squad

@jackw jackw Awaiting requested review from jackw jackw is a code owner automatically assigned from grafana/plugins-platform-frontend

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90

Assignees
No one assigned
Labels
area/dashboard/templating area/explore area/frontend area/panel/canvas Issues related to canvas panel area/panel/timeseries The main time series Graph panel area/panel/xychart datasource/Azure Azure Monitor Datasource datasource/Elasticsearch datasource/Loki datasource/Prometheus no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/accessibility Accessibility problem / enhancement wcag/3.3.2 Labels or instructions are provided when content requires user input.
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.

None yet