Flamegraph: Fix tooltip positioning #67938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafanabot
pushed a commit
that referenced
this pull request
May 11, 2023
(cherry picked from commit 37de4a8)
ryantxu
pushed a commit
that referenced
this pull request
May 11, 2023
aocenas
added a commit
that referenced
this pull request
May 12, 2023
ryantxu
pushed a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip that is shown when hovering over flamegraph nodes had the wrong position. This was broken by #64428 but mainly because the positioning relied on double rendering of the component so the actual repositioning was done on remount. The Tooltip component itself isn't working in a way that would allow it to track moving trigger element.
This rewrites this to use a simple fixed-positioned div with the same styling as the tooltip.