Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Some type fixes needed for react 18 #65600

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Chore: Some type fixes needed for react 18 #65600

merged 1 commit into from
Mar 30, 2023

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

Why do we need this feature?

  • better types across grafana
  • prereq for react 18

Who is this feature for?

  • grafana devs

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@ashharrison90 ashharrison90 added type/chore no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Mar 30, 2023
@ashharrison90 ashharrison90 added this to the 9.5.0 milestone Mar 30, 2023
@ashharrison90 ashharrison90 self-assigned this Mar 30, 2023
@ashharrison90 ashharrison90 requested review from a team as code owners March 30, 2023 10:11
@ashharrison90 ashharrison90 requested review from axelavargas, evictorero and yaelleC and removed request for a team March 30, 2023 10:11
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 27 existing alerts. Please check the repository Security tab to see all alerts.

joey-grafana
joey-grafana approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@joey-grafana joey-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tempo + flame graph top table looks good!

@ashharrison90 ashharrison90 merged commit 98e6665 into main Mar 30, 2023
@ashharrison90 ashharrison90 deleted the ash/react-18-type-fixes branch March 30, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joey-grafana joey-grafana joey-grafana approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt

@axelavargas axelavargas Awaiting requested review from axelavargas axelavargas is a code owner automatically assigned from grafana/dashboards-squad

@evictorero evictorero Awaiting requested review from evictorero evictorero is a code owner automatically assigned from grafana/dashboards-squad

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC was automatically assigned from grafana/grafana-frontend-platform

Assignees

@ashharrison90 ashharrison90

Labels
area/frontend datasource/Tempo no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashharrison90 @joey-grafana @grafanabot