Chore: Better typings in @grafana/ui needed for react 18
#64828
Conversation
ashharrison90
added
type/chore
no-backport
ashharrison90
requested review from
mckn,
tskarhed and
JoaoSilvaGrafana
and removed request for
a team
| export const ControlledCollapse: FunctionComponent<Props> = ({ isOpen, onToggle, ...otherProps }) => { | ||
| export const ControlledCollapse = ({ isOpen, onToggle, ...otherProps }: React.PropsWithChildren<Props>) => { |
There was a problem hiding this comment.
Alternatively, we could just type children: React.ReactNode inProps. At the risk of bikeshedding this, might be worth checking with broader group for what pattern we want to prefer.
There was a problem hiding this comment.
agreed, think it's worth discussing in a frontend weekly. don't think it needs to hold out this specific PR since we already have both throughout the codebase (😅).
i would propose using React.PropsWithChildren more tbh. it comes from react, so if they ever change the children type (extremely unlikely i know) it would be a no-op. and it removes any chance of an incorrect type being set (what was it again... was it React.ReactNode, React.ReactElement or JSX.Element? 🤔)
There was a problem hiding this comment.
it's just React.ReactNode. always React.ReactNode 😅
I think.
| @@ -1,5 +1,5 @@ | |||
| import { css, cx } from '@emotion/css'; | |||
| import React, { FunctionComponent, useState } from 'react'; | |||
| @@ -1,2 +0,0 @@ | |||
| export type Renderable = React.ComponentType | JSX.Element; | |||
|
(Open the links below in a new tab to go to the correct steps)
|
grafanabot
added
the
levitate breaking change
What is this feature?
Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer: