Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Upgrade to react 18 #64428

Merged
merged 69 commits into from
Apr 11, 2023
Merged

Chore: Upgrade to react 18 #64428

merged 69 commits into from
Apr 11, 2023

Commits on Mar 8, 2023

  1. update react 18 related deps

    @ashharrison90
    ashharrison90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    0a6064b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    bd325e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. fix some types

    @ashharrison90
    ashharrison90 committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    ae4f4d7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    a679c74 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    7a8e1a9 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    7652c93 View commit details
    Browse the repository at this point in the history

  2. make sure we're on react-router-dom >= 5.3.3

    @ashharrison90
    ashharrison90 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    0549d8b View commit details
    Browse the repository at this point in the history

  3. Use new root API

    @kaydelaney @ashharrison90
    kaydelaney authored and ashharrison90 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    8b8232e View commit details
    Browse the repository at this point in the history

  4. Remove StrictMode for now - react 18 double rendering causes issues

    @ashharrison90
    ashharrison90 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    570d594 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cc01302 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    747b50e View commit details
    Browse the repository at this point in the history

  2. fix + ignore some @grafana/ui types

    @ashharrison90
    ashharrison90 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    cb0ca7e View commit details
    Browse the repository at this point in the history

  3. fix some more types

    @ashharrison90
    ashharrison90 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    423483a View commit details
    Browse the repository at this point in the history

  4. use renderHook from @testing-library/react in almost all cases

    @ashharrison90
    ashharrison90 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    13f45f5 View commit details
    Browse the repository at this point in the history

  5. fix storybook types

    @ashharrison90
    ashharrison90 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    846b883 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. rewrite useDashboardSave to not use useEffect

    @ashharrison90
    ashharrison90 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    7b97fab View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. make props optional

    @ashharrison90
    ashharrison90 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    53f29f0 View commit details
    Browse the repository at this point in the history

  2. only render if props are provided

    @ashharrison90
    ashharrison90 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    2b9d8dd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    e3c14d1 View commit details
    Browse the repository at this point in the history

  4. add correct type for useCallback

    @ashharrison90
    ashharrison90 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ceb9d7d View commit details
    Browse the repository at this point in the history

  5. make resourcepicker tests more robust

    @ashharrison90
    ashharrison90 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    d6bac45 View commit details
    Browse the repository at this point in the history

  6. fix ModalManager rendering

    @ashharrison90
    ashharrison90 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    baff119 View commit details
    Browse the repository at this point in the history

  7. fix some more unit tests

    @ashharrison90
    ashharrison90 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    9ab3067 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. store the click coordinates in a ref as setState is NOT synchronous

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    71ef071 View commit details
    Browse the repository at this point in the history

  2. fix remaining e2e tests

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    1b9f4c1 View commit details
    Browse the repository at this point in the history

  3. rewrite dashboardpage tests to avoid act warnings

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    7c39cda View commit details
    Browse the repository at this point in the history

  4. undo lint ignores

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    0c39815 View commit details
    Browse the repository at this point in the history

  5. fix ExpanderCell types

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    9606b06 View commit details
    Browse the repository at this point in the history

  6. set SymbolCell type correctly

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    31b59c4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    7afe79b View commit details
    Browse the repository at this point in the history

  8. fix QueryAndExpressionsStep

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    0c45018 View commit details
    Browse the repository at this point in the history

  9. looks like the types were actually wrong instead :D

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    46f99d1 View commit details
    Browse the repository at this point in the history

  10. undo this for now...

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    2438f13 View commit details
    Browse the repository at this point in the history

  11. remove spinner waits

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    3f16481 View commit details
    Browse the repository at this point in the history

  12. more robust tests

    @ashharrison90
    ashharrison90 committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    307f3c9 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. rewrite errorboundary test to not explicitly count the number of renders

    @ashharrison90
    ashharrison90 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    ffa4ecb View commit details
    Browse the repository at this point in the history

  2. make urlParam expect async

    @ashharrison90
    ashharrison90 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    b2d103b View commit details
    Browse the repository at this point in the history

  3. increase timeout in waitFor

    @ashharrison90
    ashharrison90 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    34cdf50 View commit details
    Browse the repository at this point in the history

  4. revert ExplorePage test changes

    @ashharrison90
    ashharrison90 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    cabc9b6 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Update public/app/features/dashboard/containers/DashboardPage.test.tsx 

    Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
    @ashharrison90 @Clarity-89
    ashharrison90 and Clarity-89 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    3324cea View commit details
    Browse the repository at this point in the history

  2. Update public/app/features/dashboard/containers/PublicDashboardPage.t… 

    …est.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
    @ashharrison90 @Clarity-89
    ashharrison90 and Clarity-89 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    09633dc View commit details
    Browse the repository at this point in the history

  3. Update public/app/features/dashboard/containers/PublicDashboardPage.t… 

    …est.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
    @ashharrison90 @Clarity-89
    ashharrison90 and Clarity-89 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    36f2511 View commit details
    Browse the repository at this point in the history

  4. Update public/app/features/dashboard/containers/PublicDashboardPage.t… 

    …est.tsx

Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>
    @ashharrison90 @Clarity-89
    ashharrison90 and Clarity-89 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    ac09842 View commit details
    Browse the repository at this point in the history

  5. skip fakeTimer test, ignore table types for now + other review comments

    @ashharrison90
    ashharrison90 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    f2580ef View commit details
    Browse the repository at this point in the history

  6. Merge branch 'ash/react-18' of https://github.com/grafana/grafana int… 

    …o ash/react-18
    @ashharrison90
    ashharrison90 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    8d4f518 View commit details
    Browse the repository at this point in the history

  7. update package peerDeps

    @ashharrison90
    ashharrison90 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    cee4037 View commit details
    Browse the repository at this point in the history

  8. small tweak to resourcepicker test

    @ashharrison90
    ashharrison90 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    bba9118 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    2aa2ddd View commit details
    Browse the repository at this point in the history

  10. update lockfile...

    @ashharrison90
    ashharrison90 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    711598a View commit details
    Browse the repository at this point in the history

  11. increase timeout in sharepublicdashboard tests

    @ashharrison90
    ashharrison90 committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    9c5fc2d View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    90dd670 View commit details
    Browse the repository at this point in the history

  2. ensure ExplorePaneContainer passes correct queries to initializeExplore

    @ashharrison90
    ashharrison90 committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    c94bc79 View commit details
    Browse the repository at this point in the history

  3. fix LokiContextUI test

    @ashharrison90
    ashharrison90 committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    b03b23a View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    b08bb9c View commit details
    Browse the repository at this point in the history

  2. fix unit tests

    @ashharrison90
    ashharrison90 committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    1b71bfb View commit details
    Browse the repository at this point in the history

  3. make importDashboard flow more consistent

    @ashharrison90
    ashharrison90 committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    56a874d View commit details
    Browse the repository at this point in the history

  4. wait for dashboard name before continuing

    @ashharrison90
    ashharrison90 committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    346151d View commit details
    Browse the repository at this point in the history

  5. more test fixes

    @ashharrison90
    ashharrison90 committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    8a8b919 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    2fcb339 View commit details
    Browse the repository at this point in the history

  2. readd dashboard name to variable e2e tests

    @ashharrison90
    ashharrison90 committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    cfc57b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. wait for switches to be enabled before clicking

    @ashharrison90
    ashharrison90 committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b20f267 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    d1483a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    8f3a402 View commit details
    Browse the repository at this point in the history

  2. fix modal rendering

    @ashharrison90
    ashharrison90 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f633691 View commit details
    Browse the repository at this point in the history

  3. don't use @testing-library/dom directly

    @ashharrison90
    ashharrison90 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    a565d87 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. quick fix for rendering of panels in firefox

    @ashharrison90
    ashharrison90 committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    3fe7f61 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Merge branch 'main' into ash/react-18

    @ashharrison90
    ashharrison90 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7655c7e View commit details
    Browse the repository at this point in the history

  2. make PromQueryField test more robust

    @ashharrison90
    ashharrison90 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3fe8563 View commit details
    Browse the repository at this point in the history

  3. don't wait for chartData - in react 18 this can happen before the wai… 

    …t code even gets executed
    @ashharrison90
    ashharrison90 committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6d1433d View commit details
    Browse the repository at this point in the history