Auth: Rotate token patch #62676
Merged
Auth: Rotate token patch #62676
+118
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Align tests
mgyongyosi
added
add to changelog
team/identity-access
backport v9.4.x
|
Hello @mgyongyosi!
Please, if the current pull request addresses a bug fix, label it with the |
mgyongyosi
force-pushed
the
mgyongyosi/auth-token-rotate-patch
branch
from
ec031c1 to
8dd4470
Compare
mgyongyosi
force-pushed
the
mgyongyosi/auth-token-rotate-patch
branch
from
8dd4470 to
f71a3d9
Compare
mgyongyosi
requested review from
papagian,
zserge and
mildwonkey
and removed request for
a team
Jguer
approved these changes
Feb 1, 2023
mgyongyosi
commented
Feb 1, 2023
mgyongyosi
commented
Feb 1, 2023
kalleep
approved these changes
Feb 2, 2023
mgyongyosi
added a commit
that referenced
this pull request
Feb 2, 2023
* Use singleflight.Group * Align tests * Cleanup (cherry picked from commit 7c1d976)
mgyongyosi
added a commit
that referenced
this pull request
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR fixes the rotate token functionality by using a
singleflight.Groupand making sure that only 1 thread updates the token when multiple parallel request are trying to rotate the same token at the same time. It meant to be an improvement for the short term and we are planning to refactor the whole session token handling part.Why do we need this feature?
Which issue(s) does this PR fix?:
Fixes #56994
Special notes for your reviewer: