Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Upgrade golangci-lint to v1.50.1 #60379

Merged
merged 2 commits into from Dec 15, 2022
Merged

Chore: Upgrade golangci-lint to v1.50.1 #60379

merged 2 commits into from Dec 15, 2022

Conversation

sakjur
Copy link
Contributor

@sakjur sakjur commented Dec 15, 2022

What is this feature?

Upgrades the linters, hopefully fixing an issue with depguard causing intermittent failures.

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

I don't think we saw this until we had two depguard rules, which wasn't backported, so hopefully we don't have to backport this.

@sakjur sakjur added type/bug no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Dec 15, 2022
@sakjur sakjur added this to the 9.4.0 milestone Dec 15, 2022
@sakjur sakjur requested a review from a team as a code owner December 15, 2022 11:08
@sakjur sakjur requested review from zserge, mildwonkey and idafurjes and removed request for a team December 15, 2022 11:08
papagian
papagian approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@papagian papagian left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that interestingly enough this change does not trigger lint-backend step

@papagian papagian mentioned this pull request Dec 15, 2022
Merged
@sakjur sakjur merged commit b7fc837 into main Dec 15, 2022
@sakjur sakjur deleted the emil/202212/upgrade-golangci-lint branch December 15, 2022 11:58
@dsotirakis dsotirakis modified the milestones: 9.4.0, 9.4.0-beta1 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papagian papagian papagian approved these changes

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@idafurjes idafurjes Awaiting requested review from idafurjes idafurjes was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
area/backend enterprise-ok no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/bug
Projects
None yet
Milestone
9.4.0-beta1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sakjur @papagian @dsotirakis @grafanabot