Dropdown: Menu now closes correctly when selecting options on touch devices #60181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
requested review from
a team,
yaelleC,
JoaoSilvaGrafana,
mckn,
codeincarnate and
oscarkilhed
and removed request for
a team
ashharrison90
changed the title
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…n touch devices (grafana#60237) Dropdown: Menu now closes correctly when selecting options on touch devices (grafana#60181) update the version of react-popper-tooltip in @grafana/ui (cherry picked from commit 75a11e9) Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
@grafana/uito use the latest version ofreact-popper-tooltipbefore
Screenshare.-.2022-12-12.4_25_51.PM.mp4
after
Screenshare.-.2022-12-12.4_23_47.PM.mp4
Why do we need this feature?
Dropdownmenus close properly on touch devicesWho is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer: