Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimePicker: Fix time picker selection #60104

Merged
merged 1 commit into from Dec 13, 2022
Merged

TimePicker: Fix time picker selection #60104

merged 1 commit into from Dec 13, 2022

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

cc @joshhunt think my review suggestion caused this 馃う instead just used your original solution of wrapping everything in a <div>

before

Screenshare.-.2022-12-09.3_34_46.PM.mp4

after

Screenshare.-.2022-12-09.3_33_37.PM.mp4

Why do we need this feature?

  • so time range selection works correctly

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

@ashharrison90 ashharrison90 added type/bug no-changelog Skip including change in changelog/release notes backport v9.3.x labels Dec 9, 2022
@ashharrison90 ashharrison90 added this to the 9.3.2 milestone Dec 9, 2022
@ashharrison90 ashharrison90 requested a review from a team as a code owner December 9, 2022 15:38
@ashharrison90 ashharrison90 self-assigned this Dec 9, 2022
@ashharrison90 ashharrison90 requested review from yaelleC and removed request for a team December 9, 2022 15:38
joshhunt
joshhunt approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@joshhunt joshhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ashharrison90 ashharrison90 merged commit 4e7a316 into main Dec 13, 2022
@ashharrison90 ashharrison90 deleted the ash/time-picker-bug branch December 13, 2022 14:11
@github-actions github-actions bot removed this from the 9.3.2 milestone Dec 13, 2022
@ashharrison90 ashharrison90 added this to the 9.3.2 milestone Dec 13, 2022
@grafanabot grafanabot mentioned this pull request Dec 13, 2022
Merged
grafanabot pushed a commit that referenced this pull request Dec 13, 2022
@ashharrison90 @grafanabot
TimePicker: Fix time picker selection (#60104)
81a6179 
fix time picker selection

(cherry picked from commit 4e7a316)
ashharrison90 added a commit that referenced this pull request Dec 13, 2022
@grafanabot @ashharrison90
[v9.3.x] TimePicker: Fix time picker selection (#60246)
3d60298 
TimePicker: Fix time picker selection (#60104)

fix time picker selection

(cherry picked from commit 4e7a316)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
@grafanabot @ashharrison90 @GuaYounesPW
[v9.3.x] TimePicker: Fix time picker selection (grafana#60246)
6e821a7 
TimePicker: Fix time picker selection (grafana#60104)

fix time picker selection

(cherry picked from commit 4e7a316)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhunt joshhunt joshhunt approved these changes

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@ashharrison90 ashharrison90

Labels
area/frontend backport v9.3.x enterprise-ok no-changelog Skip including change in changelog/release notes type/bug
Projects
Grafana Frontend Platform
Archived in project
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashharrison90 @joshhunt @grafanabot