BarChart: Fix value mappings #60066
Merged
BarChart: Fix value mappings #60066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
requested review from
ryantxu,
a team,
codeincarnate and
mdvictor
and removed request for
a team
leeoniya
commented
Dec 9, 2022
| f.config.mappings?.some((m) => { | ||
| // ValueToText mappings have a different format, where all of them are grouped into an object keyed by value | ||
| if (m.type === 'value') { | ||
| // === MappingType.ValueToText |
There was a problem hiding this comment.
this was on the previous line, until Prettier "fixed" it 馃檮
this is here because we currently have an issue with schema gen which exports enums only as types, so the values cannot be used as RHS. @sdboyer is on it, but we can probably just land it like this, since that can take more time and we'll want this fix to land in the next patch release.
There was a problem hiding this comment.
fyi, this is already fixed in #55769 - i'm just loathe to pull it out and inevitably create a merge conflict there when it's already so close
i'll do it if that PR doesn't land by next week though
ryantxu
approved these changes
Dec 9, 2022
grafanabot
pushed a commit
that referenced
this pull request
Dec 9, 2022
(cherry picked from commit 8317bf5)
leeoniya
added a commit
that referenced
this pull request
Dec 9, 2022
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
BarChart: Fix value mappings (grafana#60066) (cherry picked from commit 8317bf5) Co-authored-by: Leon Sorokin <leeoniya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59776
Fixes #60002
i broke this over a month ago in #58285
you can test this by adding any Value type mapping in any BarChart panel.
apparently my mental model of value mappings having the same structure was incorrect. they're all the same except the most common
ValueToTextone 馃う