Alerting: Use the QuotaTargetSrv instead of the QuotaTarget in quota check #60026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check Before this change, the alerting provisioning system incorrectly used the QuotaTarget to check if alerting's request quota had been reached. The quota service requires the QuotaTargetSrv, which is what's registered with the service at startup time. This is leading to errors in the provisioning system.
joeblubaugh
added
type/bug
area/alerting
papagian
approved these changes
Dec 8, 2022
|
Thanks, guys for finding this! You are the best ❗ @joeblubaugh @papagian @zserge @grobinson-grafana |
grafanabot
pushed a commit
that referenced
this pull request
Dec 8, 2022
…check (#60026) Before this change, the alerting provisioning system incorrectly used the QuotaTarget to check if alerting's request quota had been reached. The quota service requires the QuotaTargetSrv, which is what's registered with the service at startup time. This is leading to errors in the provisioning system. (cherry picked from commit e6743a7)
|
Nice fix @joeblubaugh! |
joeblubaugh
added a commit
that referenced
this pull request
Dec 8, 2022
…in quota check (#60034) Alerting: Use the QuotaTargetSrv instead of the QuotaTarget in quota check (#60026) Before this change, the alerting provisioning system incorrectly used the QuotaTarget to check if alerting's request quota had been reached. The quota service requires the QuotaTargetSrv, which is what's registered with the service at startup time. This is leading to errors in the provisioning system. (cherry picked from commit e6743a7) Co-authored-by: Joe Blubaugh <joe.blubaugh@grafana.com>
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…in quota check (grafana#60034) Alerting: Use the QuotaTargetSrv instead of the QuotaTarget in quota check (grafana#60026) Before this change, the alerting provisioning system incorrectly used the QuotaTarget to check if alerting's request quota had been reached. The quota service requires the QuotaTargetSrv, which is what's registered with the service at startup time. This is leading to errors in the provisioning system. (cherry picked from commit e6743a7) Co-authored-by: Joe Blubaugh <joe.blubaugh@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the alerting provisioning system incorrectly used the QuotaTarget to check if alerting's request quota had been reached. The quota service requires the QuotaTargetSrv, which is what's registered with the service at startup time. This is leading to errors in the provisioning system.