Login: Fix failure to login a new user via an external provider if quota are enabled #60015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papagian
requested review from
zserge,
mildwonkey and
idafurjes
and removed request for
a team
papagian
requested review from
a team,
vtorosyan and
gamab
and removed request for
a team
zserge
approved these changes
Dec 9, 2022
papagian
added a commit
that referenced
this pull request
Dec 9, 2022
…der if quota are enabled (#60086) Login: Fix failure to login a new user via an external provider if quota are enabled (#60015) * Login: Fix failure to login a new user via an external provider if quota are enabled (cherry picked from commit 341d7b0) Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…der if quota are enabled (grafana#60086) Login: Fix failure to login a new user via an external provider if quota are enabled (grafana#60015) * Login: Fix failure to login a new user via an external provider if quota are enabled (cherry picked from commit 341d7b0) Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
It fixes a bug where new users (not previously seen) coming from external providers failed to login if quota are enabled.
Quota check used to fail with:
no usage for target:org:org_user:orgbecause it used to try checking also for user and org quota during login where there was no user signed in.
This fix checks for user and org scope quota only if the
userIDandorgIDscope parameters are present.Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
To reproduce the bug one can start grafana like:
and try to login with an not existing google user.