Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeZonePicker: Scroll menu correctly when using keyboard controls #60008

Merged
merged 2 commits into from Dec 12, 2022
Merged

TimeZonePicker: Scroll menu correctly when using keyboard controls #60008

merged 2 commits into from Dec 12, 2022

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

Why do we need this feature?

  • better keyboard accessibility across Grafana

Who is this feature for?

  • everyone! 🙌

Which issue(s) does this PR fix?:

Fixes #56236

Special notes for your reviewer:

@ashharrison90 ashharrison90 added this to the 9.3.2 milestone Dec 8, 2022
@ashharrison90 ashharrison90 self-assigned this Dec 8, 2022
@ashharrison90 ashharrison90 requested a review from a team as a code owner December 8, 2022 09:48
@ashharrison90 ashharrison90 requested review from joshhunt and JoaoSilvaGrafana and removed request for a team December 8, 2022 09:48
JoaoSilvaGrafana
JoaoSilvaGrafana approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@ashharrison90 ashharrison90 merged commit 97fa63d into main Dec 12, 2022
@ashharrison90 ashharrison90 deleted the ash/56236 branch December 12, 2022 12:30
@grafanabot grafanabot mentioned this pull request Dec 12, 2022
Merged
grafanabot pushed a commit that referenced this pull request Dec 12, 2022
@ashharrison90 @grafanabot
TimeZonePicker: Scroll menu correctly when using keyboard controls (#…
7e7f7de 
…60008)

pass innerRef to TimeZoneOption so the menu scrolls properly

(cherry picked from commit 97fa63d)
ashharrison90 added a commit that referenced this pull request Dec 12, 2022
@grafanabot @ashharrison90
[v9.3.x] TimeZonePicker: Scroll menu correctly when using keyboard co…
5a0a148 
…ntrols (#60150)

TimeZonePicker: Scroll menu correctly when using keyboard controls (#60008)

pass innerRef to TimeZoneOption so the menu scrolls properly

(cherry picked from commit 97fa63d)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
@grafanabot @ashharrison90 @GuaYounesPW
[v9.3.x] TimeZonePicker: Scroll menu correctly when using keyboard co…
6fe4c63 
…ntrols (grafana#60150)

TimeZonePicker: Scroll menu correctly when using keyboard controls (grafana#60008)

pass innerRef to TimeZoneOption so the menu scrolls properly

(cherry picked from commit 97fa63d)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoSilvaGrafana JoaoSilvaGrafana JoaoSilvaGrafana approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@ashharrison90 ashharrison90

Labels
add to changelog area/frontend backport v9.3.x enterprise-ok type/accessibility Accessibility problem / enhancement type/bug
Projects
None yet
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.

A11y: In Time Picker time settings the list of time zones is not scrollable with a keyboard
3 participants
@ashharrison90 @JoaoSilvaGrafana @grafanabot