API: Fix delete user failure due to quota not enabled #59875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papagian
requested review from
sakjur,
zserge and
yangkb09
and removed request for
a team
zserge
approved these changes
Dec 6, 2022
grafanabot
pushed a commit
that referenced
this pull request
Dec 6, 2022
(cherry picked from commit 4259b6b)
papagian
added a commit
that referenced
this pull request
Dec 6, 2022
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…na#59879) API: Fix delete user failure due to quota not enabled (grafana#59875) (cherry picked from commit 4259b6b) Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
It fixes
DELETE /admin/users/{user_id}failure:This bug was introduced in #58643; there is a different quota implementation depending on whether quotas are enabled or not. The serviceDisabled should not propagate the error for methods that are called by APIs other than the quota related ones.
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #59781
Special notes for your reviewer:
This fix however has as a side effect possible orphan entries in the quota table for the deleted user if the quota are not enabled given that this call no more returns an error if the service is disabled.