Navigation: Prevent app crash when importing a dashboard with a uid of home
#59874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
requested review from
sakjur,
zserge and
idafurjes
and removed request for
a team
ashharrison90
changed the title
home no longer crashes the pagehome
joshhunt
approved these changes
Dec 9, 2022
ashharrison90
added a commit
that referenced
this pull request
Dec 9, 2022
…h a uid of `home` (#60092) Navigation: Prevent app crash when importing a dashboard with a uid of `home` (#59874) * change home id to be more unique, refactor so that home circular reference is never created * prefix starred dashboards * update reducer (cherry picked from commit a589929) Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…h a uid of `home` (grafana#60092) Navigation: Prevent app crash when importing a dashboard with a uid of `home` (grafana#59874) * change home id to be more unique, refactor so that home circular reference is never created * prefix starred dashboards * update reducer (cherry picked from commit a589929) Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
uidas thenavModel.id: https://github.com/grafana/grafana/blob/main/pkg/services/navtree/navtreeimpl/navtree.go#L345home)starred/prefix for dashboard uids so they can't clash with internal idsbuildInitialStateslightly so it can't create a circular reference on the home nodenavIndex, so when it comes to remove this circular reference it might find an incorrect nodeWhy do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #59764
Special notes for your reviewer: