Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Improved keyboard accessibility in BigValue #59830

Merged
merged 1 commit into from Dec 14, 2022
Merged

Conversation

lpskdl
Copy link
Contributor

@lpskdl lpskdl commented Dec 5, 2022

What is this feature?

  • use button instead of div
  • reset default button styles

Why do we need this feature?

  • better keyboard accessibility

Who is this feature for?

  • everyone

Which issue(s) does this PR fix?:

Fixes #59383

Special notes for your reviewer:

@lpskdl lpskdl added this to the 9.3.2 milestone Dec 5, 2022
@lpskdl lpskdl requested review from a team as code owners December 5, 2022 14:36
@lpskdl lpskdl requested review from a team, joshhunt, JoaoSilvaGrafana, academo, codeincarnate and oscarkilhed and removed request for a team December 5, 2022 14:36
@lpskdl lpskdl changed the title use appropriate elements when rendering BigValue Accessibility: Improved keyboard accessibility in BigValue Dec 5, 2022
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great leo 🙌

@lpskdl lpskdl merged commit c75ed8f into main Dec 14, 2022
@lpskdl lpskdl deleted the lpskdl/59383 branch December 14, 2022 13:28
grafanabot pushed a commit that referenced this pull request Dec 14, 2022
use appropriate elements when rendering BigValue

(cherry picked from commit c75ed8f)
lpskdl added a commit that referenced this pull request Dec 14, 2022
…60317)

Accessibility: Improved keyboard accessibility in BigValue  (#59830)

use appropriate elements when rendering BigValue

(cherry picked from commit c75ed8f)

Co-authored-by: Leo <108552997+lpskdl@users.noreply.github.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
…rafana#60317)

Accessibility: Improved keyboard accessibility in BigValue  (grafana#59830)

use appropriate elements when rendering BigValue

(cherry picked from commit c75ed8f)

Co-authored-by: Leo <108552997+lpskdl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y: Fix keyboard accessibility in packages/grafana-ui/src/components/BigValue/BigValue.tsx
3 participants