Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel Edit: Fix data links edit icons being off screen when provided title is too long #59829

Merged
merged 4 commits into from Dec 8, 2022

Conversation

dprokop
Copy link
Member

@dprokop dprokop commented Dec 5, 2022

Fixes #59150

@dprokop dprokop added this to the 9.3.2 milestone Dec 5, 2022
@dprokop dprokop requested a review from a team December 5, 2022 14:35
@dprokop dprokop self-assigned this Dec 5, 2022
@dprokop dprokop requested review from a team as code owners December 5, 2022 14:35
@grafanabot
Copy link
Contributor

Hello @dprokop!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@dprokop dprokop removed the request for review from mdvictor December 5, 2022 14:35
@dprokop dprokop requested review from a team, axelavargas and polibb and removed request for a team December 5, 2022 14:35
Copy link
Contributor

@ivanortegaalba ivanortegaalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! LGTM!
2022-12-07 10 28 25

@ivanortegaalba
Copy link
Contributor

Thanks for applying feedback, LGTM

@dprokop dprokop merged commit 6f930f4 into main Dec 8, 2022
@dprokop dprokop deleted the fix-59150 branch December 8, 2022 17:32
@grafanabot
Copy link
Contributor

The backport to v9.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-59829-to-v9.3.x origin/v9.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 6f930f48365fa06baca6cb095f216ef4a08a0c06
# Push it to GitHub
git push --set-upstream origin backport-59829-to-v9.3.x
git switch main
# Remove the local backport branch
git branch -D backport-59829-to-v9.3.x

Then, create a pull request where the base branch is v9.3.x and the compare/head branch is backport-59829-to-v9.3.x.

@grafanabot grafanabot added the backport-failed Failed to generate backport PR. Please resolve conflicts and create one manually. label Dec 8, 2022
dprokop added a commit that referenced this pull request Dec 9, 2022
…title is too long (#59829)

* Fix data links edit icons being off screen

* Remove unused imports

* Review

(cherry picked from commit 6f930f4)
dprokop added a commit that referenced this pull request Dec 9, 2022
…provided title is too long (#60082)

* Panel Edit: Fix data links edit icons being off screen when provided title is too long (#59829)

* Fix data links edit icons being off screen

* Remove unused imports

* Review

(cherry picked from commit 6f930f4)

* Fix backport
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
…provided title is too long (grafana#60082)

* Panel Edit: Fix data links edit icons being off screen when provided title is too long (grafana#59829)

* Fix data links edit icons being off screen

* Remove unused imports

* Review

(cherry picked from commit 6f930f4)

* Fix backport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend area/panel/edit backport v9.3.x backport A backport PR backport-failed Failed to generate backport PR. Please resolve conflicts and create one manually. enterprise-ok type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data-links edit and delete icons are off-screen and not visible
3 participants