TimePicker: Prevent TimePicker overflowing viewport on small screens #59808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
type/bug
add to changelog
timepicker
ashharrison90
requested review from
joshhunt,
JoaoSilvaGrafana and
lpskdl
and removed request for
a team
…solute ranges were expanded
…f the absolute ranges were expanded" This reverts commit 7090443.
grafanabot
pushed a commit
that referenced
this pull request
Dec 9, 2022
…59808) * render timepicker in a modal style on small screens * remove top: -1 * apply styles * prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded * Revert "prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded" This reverts commit 7090443. (cherry picked from commit 1497ad4)
ashharrison90
added a commit
that referenced
this pull request
Dec 9, 2022
… screens (#60100) TimePicker: Prevent TimePicker overflowing viewport on small screens (#59808) * render timepicker in a modal style on small screens * remove top: -1 * apply styles * prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded * Revert "prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded" This reverts commit 7090443. (cherry picked from commit 1497ad4) Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
… screens (grafana#60100) TimePicker: Prevent TimePicker overflowing viewport on small screens (grafana#59808) * render timepicker in a modal style on small screens * remove top: -1 * apply styles * prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded * Revert "prevent bug where selecting a relative range wouldn't apply if the absolute ranges were expanded" This reverts commit 7090443. (cherry picked from commit 1497ad4) Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
TimePickerContentin a modal forsmscreen sizesWhy do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #32369
Special notes for your reviewer:
Alternative to #59274