Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Palette: Fix not being able to type if triggered whilst another modal is open #59728

Merged
merged 1 commit into from Dec 13, 2022
Merged

Command Palette: Fix not being able to type if triggered whilst another modal is open #59728

merged 1 commit into from Dec 13, 2022

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • uses useDialog/useOverlay in the same way we do for other modals
  • this allows for multiple levels of modal and means we don't have to hook into the global keybindings
  • this also fixes some weird escape behaviour
    • before if you had the help modal open then opened the command palette, pressing escape would first close the help modal then then command palette. now pressing escape correctly closes the command palette first, then the help modal.

Why do we need this feature?

  • so users can type in the command palette no matter where it's triggered from

Who is this feature for?

  • everyone! 🙌

Which issue(s) does this PR fix?:

Fixes #56885

Special notes for your reviewer:

@ashharrison90 ashharrison90 added this to the 9.3.2 milestone Dec 2, 2022
@ashharrison90 ashharrison90 requested review from gelicia, L-M-K-B and a team December 2, 2022 14:46
@ashharrison90 ashharrison90 self-assigned this Dec 2, 2022
@ashharrison90 ashharrison90 requested review from joshhunt and yaelleC and removed request for a team December 2, 2022 14:46
@ashharrison90 ashharrison90 merged commit 535c457 into main Dec 13, 2022
@ashharrison90 ashharrison90 deleted the ash/56885 branch December 13, 2022 14:44
@grafanabot grafanabot mentioned this pull request Dec 13, 2022
Merged
grafanabot pushed a commit that referenced this pull request Dec 13, 2022
@ashharrison90 @grafanabot
Command Palette: Fix not being able to type if triggered whilst anoth…
317486d 
…er modal is open (#59728)

handle command palette in the same way as other modals

(cherry picked from commit 535c457)
ashharrison90 added a commit that referenced this pull request Dec 13, 2022
@grafanabot @ashharrison90
[v9.3.x] Command Palette: Fix not being able to type if triggered whi…
7a11627 
…lst another modal is open (#60250)

Command Palette: Fix not being able to type if triggered whilst another modal is open (#59728)

handle command palette in the same way as other modals

(cherry picked from commit 535c457)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
@grafanabot @ashharrison90 @GuaYounesPW
[v9.3.x] Command Palette: Fix not being able to type if triggered whi…
274cf25 
…lst another modal is open (grafana#60250)

Command Palette: Fix not being able to type if triggered whilst another modal is open (grafana#59728)

handle command palette in the same way as other modals

(cherry picked from commit 535c457)

Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhunt joshhunt joshhunt approved these changes

@gelicia gelicia Awaiting requested review from gelicia

@L-M-K-B L-M-K-B Awaiting requested review from L-M-K-B

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@ashharrison90 ashharrison90

Labels
add to changelog area/frontend area/navigation backport v9.3.x enterprise-ok type/bug
Projects
Grafana Frontend Platform
Archived in project
Milestone
9.3.2
Development

Successfully merging this pull request may close these issues.

Command Palette: not possible to type when keyboard shortcuts are open
3 participants
@ashharrison90 @joshhunt @grafanabot