Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureMonitor: Fix bad request when setting dimensions #59700

Merged
merged 2 commits into from Dec 2, 2022
Merged

Conversation

andresmgot
Copy link
Contributor

What is this feature?

The metric list API endpoint only supports to set the filter in the body of a POST request if the resourceID is a subscription, not a resource, causing the response to return a 400 Bad Request.

Which issue(s) does this PR fix?:

Fixes #59629

Special notes for your reviewer:

@andresmgot andresmgot requested a review from a team as a code owner December 2, 2022 10:52
@andresmgot andresmgot requested review from asimpson and aangelisc and removed request for a team December 2, 2022 10:52
@grafanabot grafanabot added area/backend datasource/Azure Azure Monitor Datasource labels Dec 2, 2022
@andresmgot andresmgot added this to the 9.3.2 milestone Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Backend code coverage report for PR #59700

Plugin Main PR Difference
azuremonitor 68.7% 68.7% 0%

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Frontend code coverage report for PR #59700
No changes

@andresmgot andresmgot merged commit a7d4bbf into main Dec 2, 2022
@andresmgot andresmgot deleted the azMonFilter branch December 2, 2022 12:17
grafanabot pushed a commit that referenced this pull request Dec 2, 2022
andresmgot added a commit that referenced this pull request Dec 2, 2022
AzureMonitor: Fix bad request when setting dimensions (#59700)

(cherry picked from commit a7d4bbf)

Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
…na#59708)

AzureMonitor: Fix bad request when setting dimensions (grafana#59700)

(cherry picked from commit a7d4bbf)

Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Monitor: Metrics Dimensions no longer work in 9.3.0
3 participants