Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Increase badge constrast to be WCAG AA compliant #59531

Merged
merged 1 commit into from Nov 30, 2022

Conversation

eledobleefe
Copy link
Contributor

What is this feature?

Darken the 'alpha' badge colour to meet AA criteria as set out in our accessibility statement.

Why do we need this feature?

Meet AA criteria as set out in our accessibility statement.

Who is this feature for?

Everyone.

Which issue(s) does this PR fix?:

Fixes #58948

Special notes for your reviewer:
After the changes, the colour of the badge is approved by the WGAC Color contrast checker.

a11y-58948

@eledobleefe eledobleefe added area/frontend type/accessibility Accessibility problem / enhancement labels Nov 30, 2022
@eledobleefe eledobleefe added this to the 9.3.1 milestone Nov 30, 2022
@eledobleefe eledobleefe self-assigned this Nov 30, 2022
@eledobleefe eledobleefe requested review from a team as code owners November 30, 2022 09:17
@eledobleefe eledobleefe requested review from a team, ashharrison90, JoaoSilvaGrafana, academo, oscarkilhed and zoltanbedi and removed request for a team November 30, 2022 09:17
@eledobleefe eledobleefe added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Nov 30, 2022
@eledobleefe eledobleefe added add to changelog backport v9.3.x and removed no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Nov 30, 2022
@grafanabot
Copy link
Contributor

Hello @eledobleefe!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👏

Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🙌

@eledobleefe eledobleefe merged commit ddc3706 into main Nov 30, 2022
@eledobleefe eledobleefe deleted the eledobleefe/a11y-language-badge-contrast-58948 branch November 30, 2022 12:21
grafanabot pushed a commit that referenced this pull request Nov 30, 2022
eledobleefe added a commit that referenced this pull request Nov 30, 2022
…ant (#59549)

Accessibility: Increase badge constrast to be WCAG AA compliant (#59531)

(cherry picked from commit ddc3706)

Co-authored-by: Laura Fernández <laura.fernandez@grafana.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
…ant (grafana#59549)

Accessibility: Increase badge constrast to be WCAG AA compliant (grafana#59531)

(cherry picked from commit ddc3706)

Co-authored-by: Laura Fernández <laura.fernandez@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Increase badge constrast to be WCAG AA compliant
4 participants