New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization: Enable internationalization by default #59204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
requested review from
zserge,
mildwonkey and
ying-jeanne
and removed request for
a team
November 23, 2022 11:25
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43050 |
ashharrison90
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well this is very exciting... 🥳
lpskdl
approved these changes
Nov 23, 2022
joshhunt
force-pushed
the
joshhunt/i18n-default-on
branch
from
November 23, 2022 13:26
946e690
to
ca87c10
Compare
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43077 |
grafanabot
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Enable internationalization feature flag by default * Change i18n feature to beta * Set i18n feature flag to stable * update features (cherry picked from commit ba0ac08)
joshhunt
added a commit
that referenced
this pull request
Nov 23, 2022
…#59226) Internationalization: Enable internationalization by default (#59204) * Enable internationalization feature flag by default * Change i18n feature to beta * Set i18n feature flag to stable * update features (cherry picked from commit ba0ac08) Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…grafana#59226) Internationalization: Enable internationalization by default (grafana#59204) * Enable internationalization feature flag by default * Change i18n feature to beta * Set i18n feature flag to stable * update features (cherry picked from commit ba0ac08) Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
internationalization
feature flag by default. This functionality will stay behind a feature flag to allow us to roll back if needed in the short term, but the feature flag will be removed entirely in a future releaseWhich issue(s) does this PR fix?:
Fixes #51578
Fixes #49280
Fixes #448
Special notes for your reviewer:
This PR just enables internationalization by default. See all previous internationalization PRs for more details about the changes.