Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solo Panel: Configurable timezone #59153

Merged
merged 3 commits into from Nov 23, 2022
Merged

Conversation

spinillos
Copy link
Member

When a user has its custom timezone, the panels are showing the user's timezone instead than the dashboard's one if dashboards are using the Default option.

This is a problem when we generating the reports because the panels are using the admin timezone if its defined instead the
dashboard's one. The result is that we are showing headers with the dashboard's timezone and panels with user's one. More context here: https://github.com/grafana/support-escalations/issues/710.

Note: I added the timezone in PanelStateWrapper but I don't know if its necessary to add it in PanelChromeAngular too.

@grafanabot
Copy link
Contributor

@spinillos spinillos added this to the 9.4.0 milestone Nov 22, 2022
@spinillos spinillos changed the title Solopanel: Configurable timezone Solo Panel: Configurable timezone Nov 22, 2022
@grafanabot
Copy link
Contributor

Copy link
Contributor

@Clarity-89 Clarity-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The milestone should be 9.3.x probably.

@spinillos spinillos modified the milestones: 9.4.0, 9.3.0 Nov 23, 2022
@spinillos spinillos merged commit a0334a9 into main Nov 23, 2022
@spinillos spinillos deleted the solopanel/configurable-timezone branch November 23, 2022 11:14
grafanabot pushed a commit that referenced this pull request Nov 23, 2022
* Allow to set timezone in query

* Use optional timestamp

* Update timeZone

(cherry picked from commit a0334a9)
spinillos added a commit that referenced this pull request Nov 23, 2022
Solo Panel: Configurable timezone (#59153)

* Allow to set timezone in query

* Use optional timestamp

* Update timeZone

(cherry picked from commit a0334a9)

Co-authored-by: Selene <selenepinillos@gmail.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
Solo Panel: Configurable timezone (grafana#59153)

* Allow to set timezone in query

* Use optional timestamp

* Update timeZone

(cherry picked from commit a0334a9)

Co-authored-by: Selene <selenepinillos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants