New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solo Panel: Configurable timezone #59153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42928 |
spinillos
changed the title
Solopanel: Configurable timezone
Solo Panel: Configurable timezone
Nov 22, 2022
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43010 |
Clarity-89
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The milestone should be 9.3.x probably.
grafanabot
pushed a commit
that referenced
this pull request
Nov 23, 2022
* Allow to set timezone in query * Use optional timestamp * Update timeZone (cherry picked from commit a0334a9)
spinillos
added a commit
that referenced
this pull request
Nov 23, 2022
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
Solo Panel: Configurable timezone (grafana#59153) * Allow to set timezone in query * Use optional timestamp * Update timeZone (cherry picked from commit a0334a9) Co-authored-by: Selene <selenepinillos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has its custom timezone, the panels are showing the user's timezone instead than the dashboard's one if dashboards are using the
Default
option.This is a problem when we generating the reports because the panels are using the admin timezone if its defined instead the
dashboard's one. The result is that we are showing headers with the dashboard's timezone and panels with user's one. More context here: https://github.com/grafana/support-escalations/issues/710.
Note: I added the timezone in
PanelStateWrapper
but I don't know if its necessary to add it inPanelChromeAngular
too.