Tempo: Send the correct start time when making a TraceQL query #59128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42873 |
CrypticSignal
changed the title
|
@CrypticSignal Is there a PR in tempo for reference? Also what was the fix is this tied to a specific Tempo version? |
aocenas
approved these changes
Nov 23, 2022
Yes and I have edited my first comment to add a link to that PR 🙂 |
grafanabot
pushed a commit
that referenced
this pull request
Nov 23, 2022
(cherry picked from commit 6d94fa6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the start time sent to the Tempo API is 0 as the API would not return any traces if the start time selected in Explore was sent. This issue has finally been fixed (grafana/tempo#1902), so the PR updates the query to send the correct start time.