Loki: Remove raw query toggle #59125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42863 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42902 |
matyax
requested changes
Nov 22, 2022
public/app/plugins/datasource/loki/components/LokiQueryEditor.test.tsx
Outdated
Show resolved
Hide resolved
|
We also need to check these failing E2E: https://drone.grafana.net/grafana/grafana/89879/3/19 |
|
@matyax my bad, i didn't mean to request this for review yet. i'm going to take a look at these errors/bugs now. |
gwdawson
requested review from
ashharrison90 and
yaelleC
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43001 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR removes the
Raw querytoggle in the builder mode and permanently shows the query.Why do we need this feature?
During user interviews we've noticed that query editor has (too) many buttons/toggles. Moreover, no users we talked to uses this to toggle their query preview off.
Who is this feature for?
...
Which issue(s) does this PR fix?:
Fixes #58511
Special notes for your reviewer:
...