Preferences: Add confirmation modal when saving org preferences #59119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 2590aeef7216ce19415b86ebb4533bc84297a881
Author: Joao Silva <joao.silva@grafana.com>
Date: Tue Nov 22 13:55:27 2022 +0000
user essentials mob! :trident:
lastFile:packages/grafana-ui/src/components/ConfirmModal/ConfirmModal.story.tsx
commit 5318737da24ba109fddecef2d6c26b1564af3ba9
Author: Leodegario Pasakdal <leodegario.pasakdal@grafana.com>
Date: Tue Nov 22 11:37:37 2022 +0100
user essentials mob! :trident:
lastFile:public/app/features/org/OrgDetailsPage.tsx
commit f0f7a7e92bb41c337e0da1068d21f2e27523c304
Author: Ashley Harrison <ashley.harrison@grafana.com>
Date: Tue Nov 22 10:24:52 2022 +0000
user essentials mob! :trident:
lastFile:public/app/core/components/SharedPreferences/SharedPreferences.tsx
commit ed80e498ef72e2945bdf2202da6e50abafc0b546
Author: joshhunt <josh@trtr.co>
Date: Tue Nov 22 10:11:43 2022 +0000
user essentials mob! :trident:
commit 435efbfca67a41714c9ca2c6c2d8a02be5685425
Author: Joao Silva <joao.silva@grafana.com>
Date: Tue Nov 22 09:59:05 2022 +0000
user essentials mob! :trident:
lastFile:public/app/core/components/SharedPreferences/SharedPreferences.tsx
Co-authored-by: joshhunt <josh@trtr.co>
Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Co-authored-by: Leodegario Pasakdal <leodegario.pasakdal@grafana.com>
JoaoSilvaGrafana
added
area/frontend
add to changelog
mob session
JoaoSilvaGrafana
requested review from
a team,
joshhunt,
ashharrison90,
jackw,
mdvictor and
supilee
and removed request for
a team
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-59119-to-v9.3.x origin/v9.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x f8dc333ee468d2d38257b867724d26dcf621b0ac
# Push it to GitHub
git push --set-upstream origin backport-59119-to-v9.3.x
git switch main
# Remove the local backport branch
git branch -D backport-59119-to-v9.3.xThen, create a pull request where the |
grafanabot
added
the
backport-failed
JoaoSilvaGrafana
added a commit
that referenced
this pull request
Nov 22, 2022
(cherry picked from commit f8dc333)
JoaoSilvaGrafana
added a commit
that referenced
this pull request
Nov 22, 2022
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This adds a confirmation modal so the user recognizes that they are making changes to the whole org and not just their own preferences:
Why do we need this feature?
At the moment if you save org preferences it is easy to forget that that will change preferences for everyone in the organization (it has happened that someone changed the language for the whole organization).
Who is this feature for?
Everyone who uses org preferences
Which issue(s) does this PR fix?:
Fixes #58635