Canvas: Add icon value mapping #59013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarrs
added
add to changelog
area/panel/canvas
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42772 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42947 |
nmarrs
changed the title
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42968 |
drew08t
approved these changes
Nov 22, 2022
grafanabot
pushed a commit
that referenced
this pull request
Nov 23, 2022
(cherry picked from commit e157ef1)
nmarrs
added a commit
that referenced
this pull request
Nov 23, 2022
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
Canvas: Add icon value mapping (grafana#59013) (cherry picked from commit e157ef1) Co-authored-by: Nathan Marrs <nathanielmarrs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received some feedback from user that #58492 did not resolve their use case. Thinking on this more it seems that a user's datasource would not return icon paths. Instead the most likely case is that a user would use value mappings to tie a given numeric value to a given icon.
We added support for icon value mapping a while ago in #44503 but limited it to only the alpha icon panel. This PR includes icon value mapping support into the canvas panel.
See community comment here
Also confirmed user can use both color and icon value mapping together
canvas.icon.value.mapping.demo.mov
Which issue(s) does this PR fix?:
Fixes #59011