Accessibility: Improve keyboard accessibility in AnnoListPanel
#58971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
type/bug
add to changelog
type/accessibility
ashharrison90
requested review from
joshhunt and
JoaoSilvaGrafana
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42524 |
JoaoSilvaGrafana
approved these changes
Nov 18, 2022
grafanabot
pushed a commit
that referenced
this pull request
Nov 21, 2022
) fix keyboard accessibility in AnnoListPanel (cherry picked from commit 598935c)
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…nel` (grafana#59015) Accessibility: Improve keyboard accessibility in `AnnoListPanel` (grafana#58971) fix keyboard accessibility in AnnoListPanel (cherry picked from commit 598935c) Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Buttonto remove an applied user filter instead of a<span>with anonClickFocusScopewhich prevents shift-tabbing in theAnnoListPanelWhy do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #58969
Special notes for your reviewer: