Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Enable interpolation for notification policies in file provisioning #58956

Merged
merged 3 commits into from Nov 22, 2022

Conversation

JohnnyQQQQ
Copy link
Member

@JohnnyQQQQ JohnnyQQQQ commented Nov 18, 2022

This PR enables interpolation for notification policies when using file provisioning. I had to work around some limitations when using a map inline by writing a custom marshaller. Everything should be explained by the comments.

Fixes #58550

@JohnnyQQQQ JohnnyQQQQ requested a review from a team as a code owner November 18, 2022 12:36
@JohnnyQQQQ JohnnyQQQQ requested review from sakjur, zserge, mildwonkey, alexweav and alexmobo and removed request for a team, sakjur, zserge and mildwonkey November 18, 2022 12:36
@JohnnyQQQQ JohnnyQQQQ changed the title Alerting: enable interpolation for notification policies in file provisioning Alerting: Enable interpolation for notification policies in file provisioning Nov 18, 2022
@grafanabot
Copy link
Contributor

@JohnnyQQQQ JohnnyQQQQ added this to the 9.3.0 milestone Nov 18, 2022
@grafanabot
Copy link
Contributor

@grafanabot
Copy link
Contributor

@JohnnyQQQQ JohnnyQQQQ added backport v9.3.x and removed no-backport Skip backport of PR labels Nov 22, 2022
@JohnnyQQQQ JohnnyQQQQ merged commit 41b3398 into main Nov 22, 2022
@JohnnyQQQQ JohnnyQQQQ deleted the alerting-provisioning-interpolation-np branch November 22, 2022 15:54
grafanabot pushed a commit that referenced this pull request Nov 22, 2022
JohnnyQQQQ added a commit that referenced this pull request Nov 22, 2022
…file provisioning (#59140)

Alerting: Enable interpolation for notification policies in file provisioning (#58956)

(cherry picked from commit 41b3398)

Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
…file provisioning (grafana#59140)

Alerting: Enable interpolation for notification policies in file provisioning (grafana#58956)

(cherry picked from commit 41b3398)

Co-authored-by: Jean-Philippe Quéméner <JohnnyQQQQ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Provision - error with environment variable interpolation for notification policies
3 participants