Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Prevent viewer role accessing dashboard creation, import and folder creation #58842

Merged
merged 1 commit into from Nov 21, 2022

Conversation

lpskdl
Copy link
Contributor

@lpskdl lpskdl commented Nov 16, 2022

What is this fix?

Prevent viewer role to access dashboard creation import and folder creation.

Which issue(s) does this PR fix?:

Fixes #58675

Special notes for your reviewer:
The change used the existing behavior how other page prevent access to certain pages based on roles.

@lpskdl lpskdl added this to the 9.3.0 milestone Nov 16, 2022
@lpskdl lpskdl requested review from a team, joshhunt and JoaoSilvaGrafana and removed request for a team November 16, 2022 15:00
@ashharrison90 ashharrison90 changed the title Navigation: Prevent viewer role to access dashboard creation import and folder creationg Navigation: Prevent viewer role to access dashboard creation import and folder creation Nov 17, 2022
@ashharrison90 ashharrison90 changed the title Navigation: Prevent viewer role to access dashboard creation import and folder creation Navigation: Prevent viewer role accessing dashboard creation, import and folder creation Nov 17, 2022
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

nice job leo 🙌

@lpskdl lpskdl merged commit 14fbd44 into main Nov 21, 2022
@lpskdl lpskdl deleted the lpskdl/58675 branch November 21, 2022 08:42
grafanabot pushed a commit that referenced this pull request Nov 21, 2022
…and folder creation (#58842)

hide pages related dashboard import create and folder creation for viewer role

(cherry picked from commit 14fbd44)
lpskdl added a commit that referenced this pull request Nov 21, 2022
…, import and folder creation (#59009)

Navigation: Prevent viewer role accessing dashboard creation, import and folder creation (#58842)

hide pages related dashboard import create and folder creation for viewer role

(cherry picked from commit 14fbd44)

Co-authored-by: Leo <108552997+lpskdl@users.noreply.github.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
…, import and folder creation (grafana#59009)

Navigation: Prevent viewer role accessing dashboard creation, import and folder creation (grafana#58842)

hide pages related dashboard import create and folder creation for viewer role

(cherry picked from commit 14fbd44)

Co-authored-by: Leo <108552997+lpskdl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation: Users with Viewer role can still open pages hidden from menu
4 participants