Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connections: Update "Your connections/Data sources" page #58589

Merged
merged 22 commits into from Nov 30, 2022
Merged

Connections: Update "Your connections/Data sources" page #58589

merged 22 commits into from Nov 30, 2022

Conversation

mikkancso
Copy link
Contributor

@mikkancso mikkancso commented Nov 10, 2022 •
edited

What is this feature?

image

Updating data source list page to match this design.

Note that the "Build a Dashboard" button is a simple link to /dashboards/new at the moment. We might want to improve it in the future.

Which issue(s) does this PR fix?:

Fixes #58310

Special notes for your reviewer:

@mikkancso mikkancso changed the title Mikkancso/58310 build your connections data sources page Connections: Update "Your connections/Data sources" page Nov 10, 2022
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/41743

leventebalogh
leventebalogh reviewed Nov 14, 2022
View reviewed changes
Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's still WIP, but looks promising! 🙌

public/app/features/datasources/state/selectors.ts Outdated Show resolved Hide resolved
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42790

@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42792

@mikkancso mikkancso force-pushed the mikkancso/58310-build-your-connections-data-sources-page branch from c376268 to 6131879 Compare November 22, 2022 12:32
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42826

@mikkancso mikkancso marked this pull request as ready for review November 22, 2022 14:10
@mikkancso mikkancso requested review from a team as code owners November 22, 2022 14:10
@mikkancso mikkancso requested a review from a team November 22, 2022 14:10
@mikkancso mikkancso requested a review from a team as a code owner November 22, 2022 14:10
@mikkancso mikkancso modified the milestones: 9.4.0, 9.3.0 Nov 22, 2022
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42845

jackw
jackw reviewed Nov 24, 2022
View reviewed changes
public/app/features/connections/pages/DataSourcesListPage.tsx
import { DataSourcesList } from 'app/features/datasources/components/DataSourcesList';

export function DataSourcesListPage() {
return (
<Page navId={'connections-your-connections-datasources'}>
<Page navId={'connections-your-connections-datasources'} actions={DataSourceAddButton()}>
Copy link
Contributor

@jackw jackw Nov 24, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we pass the DatasourceAddButton component as is to the actions prop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't, because if we do then it's not gonna be rendered.

leventebalogh
leventebalogh reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏

Left a few comments / questions.

public/app/core/components/PageActionBar/PageActionBar.tsx Outdated Show resolved Hide resolved
public/app/features/datasources/components/DataSourcesList.tsx Outdated Show resolved Hide resolved
public/app/features/datasources/pages/DataSourcesListPage.test.tsx Outdated Show resolved Hide resolved
public/app/core/components/PageActionBar/PageActionBar.tsx Show resolved Hide resolved
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43240

@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43269

leventebalogh
leventebalogh approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grafanabot
Copy link
Contributor

This pull request was removed from the 9.3.0 milestone because 9.3.0 is currently being released.

@grafanabot grafanabot removed this from the 9.3.0 milestone Nov 30, 2022
@mikkancso mikkancso added this to the 9.3.1 milestone Nov 30, 2022
@mikkancso mikkancso merged commit c723228 into main Nov 30, 2022
@mikkancso mikkancso deleted the mikkancso/58310-build-your-connections-data-sources-page branch November 30, 2022 08:41
@mikkancso mikkancso mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw left review comments

@leventebalogh leventebalogh leventebalogh approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana is a code owner automatically assigned from grafana/grafana-frontend-platform

@codeincarnate codeincarnate Awaiting requested review from codeincarnate

@supilee supilee Awaiting requested review from supilee

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@idafurjes idafurjes Awaiting requested review from idafurjes idafurjes was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/backend area/frontend enterprise-failed no-backport Skip backport of PR
Projects
None yet
Milestone
9.3.1
Development

Successfully merging this pull request may close these issues.

Build Your connections/Data sources page
4 participants
@mikkancso @grafanabot @jackw @leventebalogh